Update contributer experience #5
Conversation
KittyChiu
requested a review
from bot-digital-customer-success
as a code owner
KittyChiu
temporarily deployed
to
development
GitHub Actions
Inactive
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: lts/* |
Check notice
Code scanning / Opengrep OSS
Non-deterministic Node.js version in actions/setup-node Note
There was a problem hiding this comment.
Pull request overview
This pull request improves the contributor experience by adding automated PR labeling, enhancing the development container configuration for consistent formatting, and improving CI/CD practices. The changes focus on automation and enforcing coding standards to streamline the development workflow.
Key changes:
- Automated PR labeling workflow to track draft and review status
- Enhanced devcontainer with Prettier formatting enforcement and official extension
- CI/CD improvements including Node.js setup in linting job and daily Dependabot updates
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/pr-labels.yml |
New workflow to automatically manage draft/review labels on pull requests |
.github/workflows/pr-check.yml |
Added Node.js setup and npm dependency installation to lint job; standardized YAML string quoting; removed trailing whitespace |
.github/dependabot.yml |
Changed update frequency from weekly to daily for both GitHub Actions and npm dependencies |
.devcontainer/devcontainer.json |
Added containerUser, switched to official Prettier extension, and enforced consistent editor formatting settings |
README.md |
Added documentation for running the linter using tools/lint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: &update_run | | ||
| gh pr edit "$PR_NUMBER" --repo "$REPO" --add-label "$ADD_LABEL" || true | ||
| gh pr edit "$PR_NUMBER" --repo "$REPO" --remove-label "$REMOVE_LABEL" || true |
There was a problem hiding this comment.
YAML anchors (using &update_run and *update_run) are not supported in GitHub Actions workflow files. While valid YAML syntax, GitHub Actions will fail to parse this workflow. Each job needs to have the run commands explicitly defined rather than using YAML anchors and aliases.
| EVENT_ACTION: ${{ github.event.action }} | ||
| ADD_LABEL: ${{ env.READY_LABEL }} | ||
| REMOVE_LABEL: ${{ env.DRAFT_LABEL }} | ||
| run: *update_run |
There was a problem hiding this comment.
YAML anchors (using *update_run) are not supported in GitHub Actions workflow files. This reference to the anchor defined on line 51 will cause the workflow to fail parsing. The run commands need to be explicitly defined here.
| EVENT_ACTION: ${{ github.event.action }} | ||
| ADD_LABEL: ${{ env.ADD_LABEL_VALUE }} | ||
| REMOVE_LABEL: ${{ env.REMOVE_LABEL_VALUE }} | ||
| run: *update_run |
There was a problem hiding this comment.
YAML anchors (using *update_run) are not supported in GitHub Actions workflow files. This reference to the anchor defined on line 51 will cause the workflow to fail parsing. The run commands need to be explicitly defined here.
1 participant
This pull request introduces several improvements to the development workflow, focusing on automated pull request labeling, enhanced development container configuration, and improved CI/CD and linting practices. The most notable changes are the addition of an automated PR labeling workflow, updates to the devcontainer for consistent code formatting, and enhancements to CI/CD and dependency management.
Automated PR Labeling:
.github/workflows/pr-labels.yml) to automatically apply and remove "draft" and "ready for review" labels on pull requests based on their status changes, improving workflow visibility and management.Development Environment Improvements:
.devcontainer/devcontainer.jsonto set the container user tovscode, switch to the official Prettier extension, and enforce consistent editor and file formatting settings (e.g., tab size, final newline, trimming whitespace). [1] [2]CI/CD and Dependency Management:
.github/workflows/pr-check.yml) by adding Node.js setup andnpm cisteps, and standardized artifact upload parameters. [1] [2].yamlto.ymland increased update frequency for both GitHub Actions and npm dependencies from weekly to daily. [1] [2]Documentation:
README.mdfor running the linter withtools/lint.